All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Giampaolo Tomassoni <g.tomassoni@libero.it>
Cc: linux-kernel@vger.kernel.org, linux-atm-general@lists.sourceforge.net
Subject: Re: [ATMSAR] Request for review - update #1
Date: Sun, 04 Sep 2005 18:55:51 +0200	[thread overview]
Message-ID: <431B2717.6020706@gmail.com> (raw)
In-Reply-To: <NBBBIHMOBLOHKCGIMJMDGEHPEKAA.g.tomassoni@libero.it>

Giampaolo Tomassoni napsal(a):

>I attach a fixed version of the atmsar patch as a diff against the 2.6.13 kernel tree.
>  
>
static inline void dump_skb (char * prefix, unsigned int vc, struct 
sk_buff * skb) {
what's this? 81+ chars on line
{ on a newline, please
' * ' --> ' *'

  spin_lock_irqsave (&txq->lock, flags);
indent is tab (tab is as long as 8 chars), no 3, 4, 5 or ... spaces

and many, many others, please read CodingStyle in Documentation.

thanks,

-- 
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@gmail.com      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10


      parent reply	other threads:[~2005-09-04 16:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-04 11:05 [ATMSAR] Request for review - update #1 Giampaolo Tomassoni
2005-09-04 12:00 ` [Linux-ATM-General] " Francois Romieu
2005-09-04 13:13   ` R: " Giampaolo Tomassoni
2005-09-04 15:32     ` Francois Romieu
2005-09-04 18:44       ` R: " Giampaolo Tomassoni
2005-09-04 19:11         ` matthieu castet
2005-09-04 19:33           ` R: " Giampaolo Tomassoni
2005-09-04 19:42           ` Giampaolo Tomassoni
2005-09-05  6:05     ` Zoran Stojsavljevic
2005-09-05  6:21       ` R: " Giampaolo Tomassoni
2005-09-04 16:20 ` Alistair John Strachan
2005-09-04 16:41   ` Grzegorz Kulewski
2005-09-04 16:54     ` Alistair John Strachan
2005-09-04 17:22       ` Grzegorz Kulewski
2005-09-05 15:04       ` Duncan Sands
2005-09-04 18:36   ` R: " Giampaolo Tomassoni
2005-09-04 18:51     ` Alistair John Strachan
2005-09-05  9:36   ` David Woodhouse
2005-09-05 13:52     ` Alistair John Strachan
2005-09-05 13:56       ` David Woodhouse
2005-09-05 14:18         ` Alistair John Strachan
2005-09-05 14:32           ` David Woodhouse
2005-09-05 14:46   ` Duncan Sands
2005-09-04 16:55 ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=431B2717.6020706@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=g.tomassoni@libero.it \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.