From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andrew Morton <akpm@osdl.org>,
jmcgowan@inch.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: Kernel 2.6.13 breaks libpcap (and tcpdump).
Date: Sun, 04 Sep 2005 19:06:13 +0200 [thread overview]
Message-ID: <431B2985.1060502@trash.net> (raw)
In-Reply-To: <E1EBpkT-0001RP-00@gondolin.me.apana.org.au>
Herbert Xu wrote:
> We aren't handling the reading of specific fields like the IP protocol
> field correctly. This patch should make it work again.
I can't spot the problem, could you give me a hint?
> I tried to move this logic into the new load_pointer function but it
> all came out messy so I simply rolled it back.
case BPF_LD|BPF_W|BPF_ABS:
k = fentry->k;
load_w:
- ptr = load_pointer(skb, k, 4, &tmp);
+ if (k >= 0)
+ ptr = skb_header_pointer(skb, k, 4, &tmp);
+ else if (k < SKF_AD_OFF)
+ ptr = load_pointer(skb, k);
+ else
+ break;
The old value of ptr will be used in this case, it should
be explicitly set to NULL to abort.
next prev parent reply other threads:[~2005-09-04 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 18:44 Kernel 2.6.13 breaks libpcap (and tcpdump) John McGowan
2005-09-03 0:27 ` Andrew Morton
2005-09-04 8:21 ` Herbert Xu
2005-09-04 17:06 ` Patrick McHardy [this message]
2005-09-04 17:31 ` Patrick McHardy
2005-09-04 22:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431B2985.1060502@trash.net \
--to=kaber@trash.net \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmcgowan@inch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.