From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] Don't increase master refcount on expectations Date: Sun, 04 Sep 2005 19:47:43 +0200 Message-ID: <431B333F.8030902@trash.net> References: <430E2DF9.8060802@eurodev.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Harald Welte , Netfilter Development Mailinglist , Yasuyuki Kozakai Return-path: To: Pablo Neira In-Reply-To: <430E2DF9.8060802@eurodev.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Pablo Neira wrote: > As it's been discussed [1][2]. We shouldn't increase the master > conntrack refcount for non-fulfilled conntracks. During the conntrack > destruction, the expectations are always killed before the conntrack > itself, this guarantees that there won't be any orphan expectation. Applied, thanks. Is it correct that this also fixes the untriggerable deadlock Yasuyuki noticed?