From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiaofeng Ling <xiaofeng.ling@intel.com>
Subject: Re: [PATCH] get xenstore buffer in vmx guest
Date: Tue, 06 Sep 2005 13:29:29 +0800
Message-ID: <431D2939.1000607@intel.com>
References: <3ACA40606221794F80A5670F0AF15F84095B7041@pdsmsx403>
	<1125965755.7643.35.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1125965755.7643.35.camel@localhost.localdomain>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>, xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Rusty Russell wrote:
> On Mon, 2005-09-05 at 22:22 +0800, Ling, Xiaofeng wrote:
> 
>>Rusty Russell <mailto:rusty@rustcorp.com.au> wrote:
>>+#ifdef CONFIG_XEN
>>+static inline void *xenstore_page_virt(void)
>>+{
>>+    return (void*)mfn_to_virt(xen_start_info.store_mfn);
>>+}
> 
> 
> Great!   I think the (void*) cast is redundant though?
yes

> 
>>-postcore_initcall(xenbus_probe_init);
>>+module_init(xenbus_probe_init);
>>+MODULE_LICENSE("GPL");
> 
> 
> This should probably be:
> 	MODULE_LICENSE("Dual BSD/GPL");
ok.