All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: [NETFILTER 8/8]: Missing unlock in TCP connection tracking error path
Date: Tue, 06 Sep 2005 19:55:52 +0200	[thread overview]
Message-ID: <431DD828.2050207@trash.net> (raw)

[-- Attachment #1: 08.diff --]
[-- Type: text/x-patch, Size: 866 bytes --]

[NETFILTER]: Missing unlock in TCP connection tracking error path

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 74429d5859618a299a503db33160f27b37956bc5
tree ef0f565b47798d08ffd517c05ec6da4bdbed2acf
parent d6a220e261a31f34b644112192cc2d86278ee326
author Patrick McHardy <kaber@trash.net> Sun, 04 Sep 2005 20:07:33 +0200
committer Patrick McHardy <kaber@trash.net> Sun, 04 Sep 2005 20:07:33 +0200

 net/ipv4/netfilter/ip_conntrack_proto_tcp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/netfilter/ip_conntrack_proto_tcp.c b/net/ipv4/netfilter/ip_conntrack_proto_tcp.c
--- a/net/ipv4/netfilter/ip_conntrack_proto_tcp.c
+++ b/net/ipv4/netfilter/ip_conntrack_proto_tcp.c
@@ -349,6 +349,7 @@ static int tcp_to_nfattr(struct sk_buff 
 	return 0;
 
 nfattr_failure:
+	read_unlock_bh(&tcp_lock);
 	return -1;
 }
 #endif

                 reply	other threads:[~2005-09-06 17:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=431DD828.2050207@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.