From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [NETFILTER 2/8]: Add NetBIOS name service helper Date: Wed, 07 Sep 2005 05:01:20 +0200 Message-ID: <431E5800.9080406@trash.net> References: <431DD813.8010309@trash.net> <431DDB7C.3010503@trash.net> <20050906.195649.54560179.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org, sbellabes@mandriva.com Return-path: To: "David S. Miller" In-Reply-To: <20050906.195649.54560179.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org David S. Miller wrote: > From: Samir Bellabes > Subject: Re: [NETFILTER 2/8]: Add NetBIOS name service helper > Date: Wed, 07 Sep 2005 04:50:16 +0200 > > >>[NETFILTER] Return NF_DROP if expectation failed for Netbios conntrack >> >>Fix the returned value when it's not possible to allocate expectation >>or if ip_conntrack_expect_related() failed. >> >>Signed-off-by: Samir Bellabes > > > Patrick, I've applied this, I hope you don't mind :) Actually it was deliberate, I don't see a reason why the packet should be dropped, its best effort. Besides that the patch creates a reference leak, we always need to call ip_conntrack_expect_put. Please revert the patch. Thanks.