From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: dev@dpdk.org, jerinj@marvell.com, pbhagavatula@marvell.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix build on arm64
Date: Mon, 28 Oct 2019 17:34:36 +0100 [thread overview]
Message-ID: <4320268.0ttSs8cEyt@xps> (raw)
In-Reply-To: <20191028112535.692-1-alialnu@mellanox.com>
28/10/2019 12:25, Ali Alnubani:
> OcteonTx was disabled for causing an internal compiler error on old gcc
> versions.
> See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers").
>
> The condition that was added later to apply disabling OcteonTx
> only on arm64 caused the condition to never be obeyed because it
> compares ["arm64"] to [arm64].
>
> This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH,
> because the former has the quotes removed, while the later doesn't.
>
> Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> - ifeq ($(CONFIG_RTE_ARCH), arm64)
> + ifeq ($(RTE_ARCH), arm64)
Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2019-10-28 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 11:25 [dpdk-dev] [PATCH 1/2] mk: fix build on arm64 Ali Alnubani
2019-10-28 11:25 ` [dpdk-dev] [PATCH 2/2] mk: disable OcteonTx2 on old compilers Ali Alnubani
2019-10-30 11:49 ` Jerin Jacob
2019-10-28 16:34 ` Thomas Monjalon [this message]
2019-10-30 11:42 ` [dpdk-dev] [PATCH 1/2] mk: fix build on arm64 Jerin Jacob
2019-11-04 13:30 ` [dpdk-dev] [PATCH v2 " Ali Alnubani
2019-11-04 13:30 ` [dpdk-dev] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers Ali Alnubani
2019-11-08 15:32 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4320268.0ttSs8cEyt@xps \
--to=thomas@monjalon.net \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.