All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: James.Bottomley@SteelEye.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] SCSI: Don't be so verbose if no disc is present
Date: Fri, 09 Sep 2005 23:17:16 +0100	[thread overview]
Message-ID: <432209EC.90900@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Running a simple "touch /dev/scd0" on a SCSI cdrom will cause the following 
message to appear in the logs if no disc is present:

	Device not ready. Make sure there is a disc in the drive.

This results in the logs being flooded for some users by those userspace 
agents which repeatedly poll the device for media change.

This patch demotes the message to a quieter scsi-logging message only.

Signed-off-by: Daniel Drake <dsd@gentoo.org>


[-- Attachment #2: scsi-quiet-no-cd-warning.patch --]
[-- Type: text/x-patch, Size: 612 bytes --]

--- linux/drivers/scsi/scsi_ioctl.c.orig	2005-09-09 23:10:07.000000000 +0100
+++ linux/drivers/scsi/scsi_ioctl.c	2005-09-09 23:13:17.000000000 +0100
@@ -118,8 +118,9 @@ static int ioctl_internal_command(struct
 			break;
 		case NOT_READY:	/* This happens if there is no disc in drive */
 			if (sdev->removable && (cmd[0] != TEST_UNIT_READY)) {
-				printk(KERN_INFO "Device not ready. Make sure"
-				       " there is a disc in the drive.\n");
+				SCSI_LOG_IOCTL(2, printk(
+				       "Device not ready. Make sure"
+				       " there is a disc in the drive.\n"));
 				break;
 			}
 		case UNIT_ATTENTION:

             reply	other threads:[~2005-09-09 22:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-09 22:17 Daniel Drake [this message]
2005-09-09 22:35 ` [PATCH] SCSI: Don't be so verbose if no disc is present Patrick Mansfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432209EC.90900@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.