All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sgi.com>
To: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: clear uptodate in 2.6's discard_buffer()?
Date: Mon, 12 Sep 2005 09:38:49 -0500	[thread overview]
Message-ID: <432592F9.2020806@sgi.com> (raw)

I was tracking down a problem in xfs, which led me to discover that 
discard_buffer(), in my case called when truncating a file, does not 
clear the Uptodate flag on the bh.

It looks like clearing Uptodate was removed fairly specifically in the 
2.6 tree, long ago, as part of a much larger changeset:

http://linux.bkbits.net:8080/linux-2.6/cset@1.373.70.7?nav=index.html|src/|src/fs|related/fs/buffer.c

At first glance it seems odd to me that we would clear dirty, mapped, 
req, new, and delay flags, and also NULL out the b_bdev, but leave 
buffers marked as uptodate.

Is there a reason to leave the uptodate flag, or is this an oversight?

Thanks,

-Eric

                 reply	other threads:[~2005-09-12 14:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432592F9.2020806@sgi.com \
    --to=sandeen@sgi.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.