From: Mike Christie <michaelc@cs.wisc.edu>
To: Timothy Thelin <Timothy.Thelin@wdc.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6.13] scsi: sd fails to copy cmd_len on SG_IO
Date: Tue, 13 Sep 2005 14:05:13 -0500 [thread overview]
Message-ID: <432722E9.1090904@cs.wisc.edu> (raw)
In-Reply-To: <CA45571DE57E1C45BF3552118BA92C9D69BDDB@WDSCEXBECL03.sc.wdc.com>
Timothy Thelin wrote:
>
>>-----Original Message-----
>>From: Mike Christie [mailto:michaelc@cs.wisc.edu]
>>Sent: Tuesday, September 13, 2005 10:49 AM
>>To: Timothy Thelin
>>Cc: James Bottomley; SCSI Mailing List; Linux Kernel; Andrew Morton
>>Subject: Re: [PATCH 2.6.13] scsi: sd fails to copy cmd_len on SG_IO
>>
>>
>>Timothy Thelin wrote:
>>
>>>This fixes an issue when doing SG_IO on an sd device: the
>>>sd driver fails to copy the request's cmd_len to the scsi
>>>command's cmd_len when initializing the command.
>>>
>>
>>Do you need the same fix to st, sr, and scsi_lib (in the
>>scsi_generic_done path)?
>>
>
>
> I just looked, and st and sr look like they need the same fix, but i'm
> unaware of where scsi_lib might need it (I'm new to the Linux scsi stack).
> Mind elaborating on your thoughts of the scsi_generic_done path? (I cant
> find
> the symbol in drivers/scsi/*)
>
look at the bottom of scsi_prep_fn() in scsi_lib.c. SCSI-ml will do
block_pc commands (which come down like block layer SG_IO ones) for
things like inquiry and report luns when scanning a host. At that time
there is no upper layer driver like sd attached so scsi_generic_done()
is used as a callback for finishing up commands.
next prev parent reply other threads:[~2005-09-13 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 18:26 [PATCH 2.6.13] scsi: sd fails to copy cmd_len on SG_IO Timothy Thelin
2005-09-13 19:05 ` Mike Christie [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-13 17:39 Timothy Thelin
2005-09-13 17:48 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432722E9.1090904@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@SteelEye.com \
--cc=Timothy.Thelin@wdc.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.