All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Staubach <staubach@redhat.com>
To: Assar <assar@permabit.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	Trond Myklebust <trond.myklebust@fys.uio.no>,
	Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs client, kernel 2.4.31: readlink result overflow
Date: Tue, 13 Sep 2005 16:36:59 -0400	[thread overview]
Message-ID: <4327386B.5050201@redhat.com> (raw)
In-Reply-To: <784q8okdfn.fsf@sober-counsel.permabit.com>

Assar wrote:

>>If thats the reason, you don't need the "-1" there?
>>    
>>
>
>It also writes a 0 byte.  I think it looks like this:
>
>---- ------------ -
>len  string...    0
>
>-
>

NFS uses XDR to encode C strings.  They are encoded as counted byte arrays
and are _not_ null terminated.  The space containing the string is rounded
up to the next 4 byte boundary though and, usually, this space is zero 
filled.
The number of bytes in the string is encoded as a big endian integer in the
first four bytes.

    Thanx...

       ps

  parent reply	other threads:[~2005-09-13 20:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-12 13:26 [PATCH] nfs client, kernel 2.4.31: readlink result overflow Assar
2005-09-12 18:46 ` Valdis.Kletnieks
2005-09-12 19:37   ` Assar
2005-09-12 20:01     ` Valdis.Kletnieks
2005-09-12 20:41       ` Assar
2005-09-12 20:53         ` Valdis.Kletnieks
2005-09-13 18:39         ` Marcelo Tosatti
2005-09-13 18:52           ` Assar
2005-09-13 19:35             ` Marcelo Tosatti
2005-09-13 20:01               ` Assar
2005-09-14 18:55                 ` Peter Staubach
2005-09-14 19:41                   ` Assar
2005-09-14 20:11                     ` Peter Staubach
2005-09-14 22:20                       ` Assar
2005-09-14 22:26                         ` Peter Staubach
2005-09-14 20:15                     ` Peter Staubach
2005-09-14 20:26                       ` Assar
2005-09-14 20:27                         ` Peter Staubach
2005-09-14 20:59                           ` Assar
2005-09-13 20:36             ` Peter Staubach [this message]
2005-09-13 20:55               ` Assar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4327386B.5050201@redhat.com \
    --to=staubach@redhat.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=assar@permabit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.