From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] Prevent xend from starting duplicate domains Date: Tue, 13 Sep 2005 23:32:35 -0500 Message-ID: <4327A7E3.1090602@us.ibm.com> References: <87d5ncsksl.fsf@us.ibm.com> <43275ED7.2090709@blueyonder.co.uk> <878xy0sebq.fsf@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <878xy0sebq.fsf@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Smith , xen-devel , David Hopwood List-Id: xen-devel@lists.xenproject.org Dan Smith wrote: >DH> Surely there's a race condition here? The hypervisor op that >DH> creates a domain has to fail if it would result in two domains >DH> with the same name; > >With the same domid? Yes. Unless I'm completely missing something, >the hypervisor knows nothing of the *names* of the domains. > > The hypervisor has no concept of domain names. That's entirely a Xend construct. The same applies to UUIDs. Even if there are two domains with the same name, they have different domain IDs which is okay from the hypervisor's perspective. >Am I wrong? > >DH> this can't be reliably enforced by a separate check in the Python >DH> tools. > >Going on the assumption that the names are known only to the tools, I >think the tools are the best place to perform the check. > > > Regards, Anthony Liguori