From mboxrd@z Thu Jan 1 00:00:00 1970 From: maarten.lankhorst@linux.intel.com (Maarten Lankhorst) Date: Wed, 18 Apr 2018 12:08:57 +0200 Subject: [PATCH] drm: Print unadorned pointers In-Reply-To: <1524045595.3198.11.camel@synopsys.com> References: <20180418092450.13798-1-abrodkin@synopsys.com> <1524045595.3198.11.camel@synopsys.com> List-ID: Message-ID: <432801bd-a775-5b48-00c4-2160ae52c25b@linux.intel.com> To: linux-snps-arc@lists.infradead.org Op 18-04-18 om 11:59 schreef Alexey Brodkin: > On Wed, 2018-04-18@11:29 +0200, Maarten Lankhorst wrote: >> Op 18-04-18 om 11:24 schreef Alexey Brodkin: >>> After commit ad67b74 ("printk: hash addresses printed with %p") >>> pointers are being hashed when printed. However, this makes >>> debug output completely useless. Switch to %px in order to see the >>> unadorned kernel pointers. >>> >>> This was done with the following one-liner: >>> find drivers/gpu/drm -type f -name "*.c" -exec sed -r -i '/DRM_DEBUG|KERN_DEBUG|pr_debug/ s/%p\b/%px/g' {} + >> So first we plug a kernel information leak hole, then we introduce it again? Seems like a terrible idea.. > Well security concerns are good but what about us poor kernel developers? > Those debug prints are supposed to help us to deal with stuff we develop or fix. > > Frankly I was quite surprised when first saw what was "unique hashed ID" instead > of real pointer value. And what's worse there's no way to get previous behavior back. > So now we have to manually patch sources here and there to get meaningful data, right? > > I wouldn't bother sending this patch if there was Kconfig option reverting %p behavior > but that was never implemented. > > -Alexey There's %pK for kernel pointers. It does what you want and can be toggled with kptr_restrict, without introducing security holes. :) Perhaps split up this patch per driver, and handle the other variations as well? DRM_NOTE DRM_WARN DRM_INFO DRM_ERROR. ~Maarten From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm: Print unadorned pointers Date: Wed, 18 Apr 2018 12:08:57 +0200 Message-ID: <432801bd-a775-5b48-00c4-2160ae52c25b@linux.intel.com> References: <20180418092450.13798-1-abrodkin@synopsys.com> <1524045595.3198.11.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76F6A6E556 for ; Wed, 18 Apr 2018 10:09:14 +0000 (UTC) In-Reply-To: <1524045595.3198.11.camel@synopsys.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexey Brodkin , "dri-devel@lists.freedesktop.org" Cc: "thomas.lendacky@amd.com" , "airlied@linux.ie" , "daniel.vetter@ffwll.ch" , "cakturk@gmail.com" , "kraxel@redhat.com" , "Jerry.Zuo@amd.com" , "mingo@kernel.org" , "thellstrom@vmware.com" , "vincent.abriou@st.com" , "linux@armlinux.org.uk" , "krzk@kernel.org" , "maxime.ripard@bootlin.com" , "wens@csie.org" , "Hongbo.He@amd.com" , "airlied@redhat.com" , "bp@suse.de" , "arnd@arndb.de" , "sunpeng.li@amd.com" , "rodrigo.vivi@intel.com" , "matthias.bgg@gmail.com" , Tony.Cheng@ List-Id: dri-devel@lists.freedesktop.org T3AgMTgtMDQtMTggb20gMTE6NTkgc2NocmVlZiBBbGV4ZXkgQnJvZGtpbjoKPiBPbiBXZWQsIDIw MTgtMDQtMTggYXQgMTE6MjkgKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+PiBPcCAx OC0wNC0xOCBvbSAxMToyNCBzY2hyZWVmIEFsZXhleSBCcm9ka2luOgo+Pj4gQWZ0ZXIgY29tbWl0 IGFkNjdiNzQgKCJwcmludGs6IGhhc2ggYWRkcmVzc2VzIHByaW50ZWQgd2l0aCAlcCIpCj4+PiBw b2ludGVycyBhcmUgYmVpbmcgaGFzaGVkIHdoZW4gcHJpbnRlZC4gSG93ZXZlciwgdGhpcyBtYWtl cwo+Pj4gZGVidWcgb3V0cHV0IGNvbXBsZXRlbHkgdXNlbGVzcy4gU3dpdGNoIHRvICVweCBpbiBv cmRlciB0byBzZWUgdGhlCj4+PiB1bmFkb3JuZWQga2VybmVsIHBvaW50ZXJzLgo+Pj4KPj4+IFRo aXMgd2FzIGRvbmUgd2l0aCB0aGUgZm9sbG93aW5nIG9uZS1saW5lcjoKPj4+ICBmaW5kIGRyaXZl cnMvZ3B1L2RybSAtdHlwZSBmIC1uYW1lICIqLmMiIC1leGVjIHNlZCAtciAtaSAnL0RSTV9ERUJV R3xLRVJOX0RFQlVHfHByX2RlYnVnLyBzLyVwXGIvJXB4L2cnIHt9ICsKPj4gU28gZmlyc3Qgd2Ug cGx1ZyBhIGtlcm5lbCBpbmZvcm1hdGlvbiBsZWFrIGhvbGUsIHRoZW4gd2UgaW50cm9kdWNlIGl0 IGFnYWluPyBTZWVtcyBsaWtlIGEgdGVycmlibGUgaWRlYS4uCj4gV2VsbCBzZWN1cml0eSBjb25j ZXJucyBhcmUgZ29vZCBidXQgd2hhdCBhYm91dCB1cyBwb29yIGtlcm5lbCBkZXZlbG9wZXJzPwo+ IFRob3NlIGRlYnVnIHByaW50cyBhcmUgc3VwcG9zZWQgdG8gaGVscCB1cyB0byBkZWFsIHdpdGgg c3R1ZmYgd2UgZGV2ZWxvcCBvciBmaXguCj4KPiBGcmFua2x5IEkgd2FzIHF1aXRlIHN1cnByaXNl ZCB3aGVuIGZpcnN0IHNhdyB3aGF0IHdhcyAidW5pcXVlIGhhc2hlZCBJRCIgaW5zdGVhZAo+IG9m IHJlYWwgcG9pbnRlciB2YWx1ZS4gQW5kIHdoYXQncyB3b3JzZSB0aGVyZSdzIG5vIHdheSB0byBn ZXQgcHJldmlvdXMgYmVoYXZpb3IgYmFjay4KPiBTbyBub3cgd2UgaGF2ZSB0byBtYW51YWxseSBw YXRjaCBzb3VyY2VzIGhlcmUgYW5kIHRoZXJlIHRvIGdldCBtZWFuaW5nZnVsIGRhdGEsIHJpZ2h0 Pwo+Cj4gSSB3b3VsZG4ndCBib3RoZXIgc2VuZGluZyB0aGlzIHBhdGNoIGlmIHRoZXJlIHdhcyBL Y29uZmlnIG9wdGlvbiByZXZlcnRpbmcgJXAgYmVoYXZpb3IKPiBidXQgdGhhdCB3YXMgbmV2ZXIg aW1wbGVtZW50ZWQuCj4KPiAtQWxleGV5CgpUaGVyZSdzICVwSyBmb3Iga2VybmVsIHBvaW50ZXJz LiBJdCBkb2VzIHdoYXQgeW91IHdhbnQgYW5kIGNhbiBiZSB0b2dnbGVkIHdpdGgga3B0cl9yZXN0 cmljdCwgd2l0aG91dCBpbnRyb2R1Y2luZyBzZWN1cml0eSBob2xlcy4gOikKClBlcmhhcHMgc3Bs aXQgdXAgdGhpcyBwYXRjaCBwZXIgZHJpdmVyLCBhbmQgaGFuZGxlIHRoZSBvdGhlciB2YXJpYXRp b25zIGFzIHdlbGw/CgpEUk1fTk9URSBEUk1fV0FSTiBEUk1fSU5GTyBEUk1fRVJST1IuCgoKfk1h YXJ0ZW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=