From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Theurer Subject: Re: [PATCH] fix network-bridge stop Date: Wed, 14 Sep 2005 12:25:43 -0500 Message-ID: <43285D17.90803@us.ibm.com> References: <200509141051.57727.habanero@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > > On 14 Sep 2005, at 16:51, Andrew Theurer wrote: > >> During my attempts to get the latest bridge networking model working >> on my >> system, I often invoked 'network-bridge stop' with total failure. >> Attached >> is an updated version that works. > > > Just to clarify: presumably the problem with the current script, that > your patch fixes, is that it tests for and tears down veth0, when in > fact veth0 has been renamed to eth0, and eth0 to peth0? :-) Yes, the script in current xen-unstable, when running "stop", tests for veth0, which does not exist because it has been renamed to eth0. It now tests for peth0, since that is the only real indication that veth0 was used in the first place. There are other small fixes like removal or hard coded "peth0", removal of unconditional 'brctl delif xen-br0 eth0', and reversal of ethernet naming. -Andrew