All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dougg@torque.net>
To: Christoph Hellwig <hch@lst.de>
Cc: matthew@wil.cx, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sym2: remove code to handle DMA_BIDIRECTION requests
Date: Thu, 15 Sep 2005 22:12:33 +1000	[thread overview]
Message-ID: <43296531.5090709@torque.net> (raw)
In-Reply-To: <20050914134131.GA9700@lst.de>

Christoph Hellwig wrote:
> The upper layer doesn't send these down since 2.4.x (or 2.6 in
> practice), so no need to handle it.  Inline sym_setup_data_pointers
> into it's only caller so we can fail gracefully in the case we'd get
> one neverless.

Christoph,
I have no objection to this patch.

I would like to flag that at some stage in the
future the SCSI (or whatever it may be called)
subsystem will need to support true bidirectional
commands (there are a few of these in SBC-2 and
lots of them in OSD). To do it properly I think we
need two scatter gather lists, one for data out
(to the device) and one for data in (from the device).
The SBC-2 XDWRITEREAD command indicates that the data out
is done before the data in (from the device); I'm not
sure whether that ordering is always the case.

Doug Gilbert


  reply	other threads:[~2005-09-15 12:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-14 13:41 [PATCH] sym2: remove code to handle DMA_BIDIRECTION requests Christoph Hellwig
2005-09-15 12:12 ` Douglas Gilbert [this message]
2005-09-15 12:16   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43296531.5090709@torque.net \
    --to=dougg@torque.net \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.