From: Douglas Gilbert <dougg@torque.net>
To: Timothy Thelin <Timothy.Thelin@wdc.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2.6.14-rc1] scsi: sd, sr, st, and scsi_lib all fail to copy cmd_len to new cmd
Date: Thu, 15 Sep 2005 22:23:23 +1000 [thread overview]
Message-ID: <432967BB.1080104@torque.net> (raw)
In-Reply-To: <CA45571DE57E1C45BF3552118BA92C9D69BDE2@WDSCEXBECL03.sc.wdc.com>
Timothy Thelin wrote:
> This fixes an issue in scsi command initialization from a request
> where sd, sr, st, and scsi_lib all fail to copy the request's
> cmd_len to the scsi command's cmd_len field.
This is an important fix. The bug is triggered whenever a SCSI
command is sent that does not conform to the old "top 3 bits of
the first byte dictate cdb length" convention. This mainly happens
with vendor specific commands and with variable length commands
(those starting with opcode 0x7f). The latter is not a problem
today because linux doesn't support variable length commands
(or, to be more precise, those commands with more than 16 bytes
in them).
Doug Gilbert
prev parent reply other threads:[~2005-09-15 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 0:03 [PATCH 2.6.14-rc1] scsi: sd, sr, st, and scsi_lib all fail to copy cmd_len to new cmd Timothy Thelin
2005-09-15 12:23 ` Douglas Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432967BB.1080104@torque.net \
--to=dougg@torque.net \
--cc=Timothy.Thelin@wdc.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.