From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] Fix another race condition in xm destroy Date: Fri, 16 Sep 2005 16:35:18 -0500 Message-ID: <432B3A96.1070005@us.ibm.com> References: <432A4D3A.6060300@us.ibm.com> <3d8eece20509161200674eff54@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3d8eece20509161200674eff54@mail.gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christian.Limpach@cl.cam.ac.uk Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Christian Limpach wrote: >On 9/16/05, Anthony Liguori wrote: > > >>There's a race condition in xm destroy that gets triggered when >>xc_domain_destroy results in a domain disappearing before we invoke the >>cleanup routines. Specifically, the saveToDB routines will through a No >>such process error. >> >>Christian, I'd appreciate if you could sanity check this before >>committing. I think it's okay because starting the cleanup shouldn't >>have any adverse effects. Having another pair of eyes confirm it would >>make me feel better though :-) >> >> > >How does it fail for you? I fixed one issue where we were clearing >the store event channel and writing that back to the store was >failing. > > You're fix solved the problem. That's why I made sure to ask, I wasn't confident my solution was correct :-) Thanks, Anthony Liguori >I'd prefer to keep doing the cleanup after destroy_domain. > > christian > > >