From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: netfilter-devel@lists.netfilter.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 3/3] NETFILTER: New PPTP helper
Date: Sat, 17 Sep 2005 18:28:44 +0200 [thread overview]
Message-ID: <432C443C.5010101@trash.net> (raw)
In-Reply-To: <20050916225131.GS8413@sunbeam.de.gnumonks.org>
Harald Welte wrote:
> On Fri, Sep 16, 2005 at 03:45:56PM -0700, David S. Miller wrote:
>
>>Why don't you guys work together to integrate all of the fixes, and
>>then resubmit PPTP as one changeset with all the bug fixes already
>>applied? I think that would work best and prevent changeset bloat.
>
> yes, ideally that would be the way for it to happen. Unfortuantely the
> PPTP helper has been around for many years (patch-o-matic-ng, latest
> version in my git tree, ...) and it apparently still didn't receive the
> kind of review it required.
The thing with patch-o-matic is that it includes tons of crap and you
never know if it includes the latest version of something, so I focus
on things submitted to the kernel. So maybe a heads-up one or two days
before submission would help. Anyway, I was just writing a mail
including some more suggestions when Dave applied the patch. I'll
go over the patch again later and send you my remaining suggestions.
next prev parent reply other threads:[~2005-09-17 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 14:54 [PATCH 3/3] NETFILTER: New PPTP helper Harald Welte
2005-09-15 22:44 ` Patrick McHardy
2005-09-16 9:15 ` Harald Welte
2005-09-16 22:45 ` David S. Miller
2005-09-16 22:51 ` Harald Welte
2005-09-17 16:28 ` Patrick McHardy [this message]
2005-09-17 17:45 ` Patrick McHardy
2005-09-18 13:28 ` Harald Welte
2005-09-18 14:26 ` Patrick McHardy
2005-09-17 18:33 ` Harald Welte
2005-09-17 19:05 ` Patrick McHardy
2005-09-18 9:14 ` Harald Welte
2005-09-18 14:37 ` Patrick McHardy
2005-09-18 6:46 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432C443C.5010101@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.