All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: axboe@suse.de, Kai Makisara <Kai.Makisara@kolumbus.fi>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] dont retry on SG_IO tape commands
Date: Sun, 18 Sep 2005 15:46:33 -0500	[thread overview]
Message-ID: <432DD229.1080201@cs.wisc.edu> (raw)
In-Reply-To: <1127073191.3067.1.camel@max>

Actually forget this patch. We can just make scsi-ml handle this.


Mike Christie wrote:
> sd does not allow scsi_io_completion to retry commands for
> SG_IO requests, and it make sense that it should not happen for st
> SG_IO commands too. This patch returns to the block layer that
> the whole command completed and relies on the caller to check
> the request errors field.
> 
> Patch was made against scsi-rc-fixes.
> 
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> 
> diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
> --- a/drivers/scsi/st.c
> +++ b/drivers/scsi/st.c
> @@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre
>  
>  static void st_intr(struct scsi_cmnd *SCpnt)
>  {
> -	scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1);
> +	scsi_io_completion(SCpnt, SCpnt->bufflen, 0);
>  }
>  
>  /*
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2005-09-18 22:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-18 19:53 [PATCH] dont retry on SG_IO tape commands Mike Christie
2005-09-18 20:46 ` Mike Christie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432DD229.1080201@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=axboe@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.