From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EH6Ie-0006Pq-8F for mharc-grub-devel@gnu.org; Sun, 18 Sep 2005 17:02:12 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EH6Ic-0006Ox-Cn for grub-devel@gnu.org; Sun, 18 Sep 2005 17:02:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EH6IY-0006N7-Q8 for grub-devel@gnu.org; Sun, 18 Sep 2005 17:02:08 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EH6IX-0006N0-Bs for grub-devel@gnu.org; Sun, 18 Sep 2005 17:02:06 -0400 Received: from [157.24.2.30] (helo=smtp1.cc.lut.fi) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EH6Hc-0003fD-OE for grub-devel@gnu.org; Sun, 18 Sep 2005 17:01:09 -0400 Received: from localhost (smtp1 [127.0.0.1]) by smtp1.cc.lut.fi (Postfix) with ESMTP id F242D7011A for ; Mon, 19 Sep 2005 00:01:05 +0300 (EEST) Received: from smtp1.cc.lut.fi ([127.0.0.1]) by localhost (smtp1.cc.lut.fi [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25613-08 for ; Mon, 19 Sep 2005 00:01:05 +0300 (EEST) Received: from [157.24.102.107] (lk4-a-4-1.lnet.lut.fi [157.24.102.107]) by smtp1.cc.lut.fi (Postfix) with ESMTP id 9B7937009B for ; Mon, 19 Sep 2005 00:01:05 +0300 (EEST) Message-ID: <432DD623.8050907@nic.fi> Date: Mon, 19 Sep 2005 00:03:31 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 1.0+ (Windows/20050809) MIME-Version: 1.0 To: The development of GRUB 2 References: <42FF3097.7030904@nic.fi> <200508141648.00325.okuji@enbug.org> <200508190248.38363.okuji@enbug.org> In-Reply-To: <200508190248.38363.okuji@enbug.org> X-Enigmail-Version: 0.92.0.0 Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Scanned: by lut.fi Content-Transfer-Encoding: quoted-printable Subject: Re: vesafb terminal for testing. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Sep 2005 21:02:10 -0000 Yoshinori K. Okuji wrote: > On Sunday 14 August 2005 16:48, Yoshinori K. Okuji wrote: >> On Sunday 14 August 2005 13:52, Vesa J=E4=E4skel=E4inen wrote: >>> I have attached patch here that adds simple terminal that uses VESA B= IOS >>> Extension 2.0+ for rendering terminal. It is not meant to be included= as >>> is in GRUB 2, but I would hope that people would test it, so I could = try >>> to improve it for greater compatibility (even though I have tried to >>> follow the standards, there might be some glitches between >>> implementations). >> That's great. I will try once I finish my current task. >=20 > So I tested it and fixed/modified many things. Sorry it took a bit longer to check those out, but after returning from my vacation it took some time to get back to normal day life. Most of the changes were good ones. I would like to know why did you add checking for reserved bit (D1) in grub2/commands/i386/pc/vbeinfo.c around line 88. There is some notes about this bit in standard (VBE 3.0, page 33, top of page) that tells that after VBE 1.2 this field has always contained value 1. In light of this I do not see need to verify for this? Also there was small semantic change in grub_vbe_probe, now if user provides info_block parameter, it will always call VESA BIOS to get information even though this would be cached in second run. I have no problem with this, but out of curiosity, was there some reason for this change? > I changed the command names to vbeinfo and vbetest. More compatible wit= h the=20 > traditional GRUB's naming scheme. Ok. > Also, you needed to use GRUB's error handling. In GRUB 2, the error is = not=20 > only a constant value, but also a message. So, whenever appropriate, yo= u=20 > should use the function grub_error. (This is a big improvement from GRU= B=20 > Legacy, really.) Thanks for informing me about that. Thanks, Vesa J=E4=E4skel=E4inen