From: Jeff Garzik <jgarzik@pobox.com>
To: David Lloyd <dmlloyd@tds.net>
Cc: linux-ide@vger.kernel.org
Subject: Re: sata_promise and SATA+PATA controllers in general
Date: Sun, 18 Sep 2005 22:11:55 -0400 [thread overview]
Message-ID: <432E1E6B.7040001@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0509181644210.10435@ultros>
David Lloyd wrote:
> Does this mean have e.g. a pata_port_ops member as well as a
> sata_port_ops member on the ata_probe_ent/ata_host_set, and mark each
> port as being either PATA or SATA with a flag of some sort? Or, would
definitely not.
> it be best to have a port_ops pointer per port?
Each port should be able to export unique behavior. That implies having
per-port hooks, since host-global hooks make it impossible for one port
to have different hooks from another port.
Establishing a global limit of two unique behaviors (sata_port_ops,
pata_port_ops) is not scalable at all.
Further complicating things, some hooks (such as ->irq_clear) are
host-wide hooks and not port-specific hooks.
Jeff
next prev parent reply other threads:[~2005-09-19 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 22:21 sata_promise and SATA+PATA controllers in general David Lloyd
2005-09-19 2:11 ` Jeff Garzik [this message]
2005-11-09 5:50 ` David Lloyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432E1E6B.7040001@pobox.com \
--to=jgarzik@pobox.com \
--cc=dmlloyd@tds.net \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.