All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Artem B. Bityutskiy" <dedekind@yandex.ru>
To: zhao forrest <zhao_fusheng@hotmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH]Add JFFS2 eraseblock header support
Date: Tue, 20 Sep 2005 15:29:16 +0400	[thread overview]
Message-ID: <432FF28C.7030005@yandex.ru> (raw)
In-Reply-To: <BAY17-F171945FE7F31D429CCE8BEE8950@phx.gbl>

hmm,

zhao forrest wrote:
> Your comments are welcome.

+struct jffs2_eraseblock_header
+{
+       jint16_t magic;
+       jint16_t nodetype; /* == JFFS2_NODETYPE_ERASEBLOCK_HEADER */
+       jint32_t totlen;
+       jint32_t hdr_crc;
+       jint32_t fs_version; /* the version of this JFFS2 fs image */
Well, I assume we may have 3 fields here:
u8 version;
u8 compat_fset;
u8 incompat_fset;
u8 rocompat_fset;

+       jint32_t erase_count; /* the erase count of this erase block */
4 bytes enough?

+       jint16_t dsize; /* the size of additional data behind node_crc */
What for?

+       jint32_t node_crc;
+       jint32_t data_crc;
+       jint32_t data[0];
+} __attribute__((packed));
+


-- 
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.

  parent reply	other threads:[~2005-09-20 11:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-20  7:45 [PATCH]Add JFFS2 eraseblock header support zhao forrest
2005-09-20 10:24 ` Jörn Engel
2005-09-20 10:59   ` Artem B. Bityutskiy
2005-09-20 11:36     ` Jörn Engel
2005-09-20 11:56       ` Artem B. Bityutskiy
2005-09-20 12:27         ` Jörn Engel
2005-09-20 12:43           ` Jörn Engel
2005-09-21  2:57       ` zhao forrest
2005-09-21  7:10         ` Jörn Engel
2005-09-21 10:42           ` Ferenc Havasi
2005-09-21  2:16     ` zhao forrest
2005-09-20 11:29 ` Artem B. Bityutskiy [this message]
2005-09-21  2:22   ` zhao forrest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432FF28C.7030005@yandex.ru \
    --to=dedekind@yandex.ru \
    --cc=linux-mtd@lists.infradead.org \
    --cc=zhao_fusheng@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.