From: Nick Piggin <nickpiggin@yahoo.com.au>
To: john stultz <johnstul@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>,
joe-lkml@rameria.de, George Anzinger <george@mvista.com>,
Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>,
Roman Zippel <zippel@linux-m68k.org>,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] NTP shift_right cleanup (v. A3)
Date: Wed, 21 Sep 2005 15:24:38 +1000 [thread overview]
Message-ID: <4330EE96.6070801@yahoo.com.au> (raw)
In-Reply-To: <1127273050.11080.34.camel@cog.beaverton.ibm.com>
john stultz wrote:
>
>+/* Required to safely shift negative values */
>+#define shift_right(x, s) ({ \
>+ __typeof__(x) __x = (x); \
>+ __typeof__(s) __s = (s); \
>+ __x < 0 ? -(-__x >> __s) : __x >> __s; \
>+})
>+
>
I'd hate to be the one to make you do another version of this ;)
However, how about having something more descriptive than shift_right?
signed_shift_right / shift_right_signed, maybe?
Nick
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2005-09-21 5:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 17:48 [RFC][PATCH] NTP shift_right cleanup (v. A1) john stultz
2005-09-14 17:53 ` john stultz
2005-09-14 18:39 ` NTP leap second question George Anzinger
2005-09-14 18:54 ` john stultz
2005-09-15 6:49 ` Ulrich Windl
2005-09-15 17:21 ` Kyle Moffett
2005-09-15 18:35 ` Alan Cox
2005-09-14 18:13 ` [RFC][PATCH] NTP shift_right cleanup (v. A1) Roman Zippel
2005-09-14 18:25 ` john stultz
2005-09-14 19:11 ` Roman Zippel
2005-09-14 18:40 ` [RFC][PATCH] NTP shift_right cleanup (v. A2) john stultz
2005-09-20 1:28 ` [PATCH] " john stultz
2005-09-21 3:24 ` [PATCH] NTP shift_right cleanup (v. A3) john stultz
2005-09-21 5:24 ` Nick Piggin [this message]
2005-09-21 8:13 ` Ulrich Windl
2005-09-21 12:18 ` Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2005-09-21 11:49 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4330EE96.6070801@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=george@mvista.com \
--cc=joe-lkml@rameria.de \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ulrich.windl@rz.uni-regensburg.de \
--cc=yoshfuji@linux-ipv6.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.