Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss

[Jay Lan <jlan@engr.sgi.com>]

Hugh Dickins wrote:
> On Wed, 21 Sep 2005, Jay Lan wrote:
> 
>>It is not really an issue of out-of-tree accounting package. The
>>system accounting is based on very old technology and needs improvement.
>>The issue we face is not an issue of one particular accounting package.
>>
>>I think the best approach would be to wrap the mm usage accounting
>>in a new CONFIG_ENHANCED_SYS_ACCT and leave it OFF by default so that
>>people can still get the minimal accounting with
>>CONFIG_BSD_PROCESS_ACCT.
> 
> 
> Yes, please: that sounds right.  With macros which dissolve to nothing
> when it's off, to avoid #ifdef CONFIG_....s throughout the source.c.
> #ifdef around the mm fields themselves?  Probably best that way.

Yes, that was the plan.

> 
> Still need a pointer in the Kconfig to some project that uses these.
> 
> Still sceptical that hiwater_vm and hiwater_rss are the magic
> missing numbers which bring system accounting into the 21st century:
> more to come?

Nah, the hiwater things were part of my enhanced accounting patches.
The io part was done as a macro as we talked about now. These are
the mm part.

System accounting improvement is needed because those accouting
information were needed and used at real customer sites.

So, yes, the basic system accounting code (ie, BSD) needs
improvement, and, no, i am done with sys acct data collection.

Thanks,
  - jay


> 
> Thanks,
> Hugh