All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Matheus Izvekov <izvekov@lps.ele.puc-rio.br>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: libata sata_sil broken on 2.6.13.1
Date: Wed, 21 Sep 2005 22:46:49 -0400	[thread overview]
Message-ID: <43321B19.7000302@pobox.com> (raw)
In-Reply-To: <60542.200.141.101.221.1126908642.squirrel@correio.lps.ele.puc-rio.br>

Matheus Izvekov wrote:
>>Essentially that is what happened.  Albert's patch simply fixed it
>>another way.
>>
>>ATA is a bit annoying in that, we try to "know" when an interrupt is
>>expected.  There is no 100% solution that simply allows us to check for
>>pending interrupts, without side effects.
>>
>>Thus the explosion when unexpected interrupts are received.
>>
> 
> 
> What do you think would be proper fix, this patch from Albert, or maybe

Albert's patch should be the proper fix.


> just trapping the interrupts (plus not have the IRQ shared with other
> devices?). Also, what keeps Albert's patch from making into mainline, it
> just needs more testing or are there any known problems?

Albert's patch needs to be fleshed out a bit more.  No fundamental 
problems, just the stuff I mentioned, plus a final review.

It also needs to be tested on EVERY controller that we support, since 
this is a fundamental change in how ALL sata devices are probed.

	Jeff



  reply	other threads:[~2005-09-22  2:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-14  1:17 libata sata_sil broken on 2.6.13.1 izvekov
2005-09-14  1:22 ` izvekov
2005-09-14 19:48 ` izvekov
2005-09-14 20:36   ` izvekov
2005-09-14 23:46     ` Andrew Morton
2005-09-15  0:19       ` izvekov
2005-09-15  5:37   ` Jeff Garzik
2005-09-15 13:27     ` Alan Cox
2005-09-15 20:13       ` izvekov
2005-09-15 22:30         ` Alan Cox
2005-09-15 22:56           ` izvekov
2005-09-16  3:42           ` izvekov
2005-09-16  6:41             ` Jeff Garzik
2005-09-16 22:10               ` Matheus Izvekov
2005-09-22  2:46                 ` Jeff Garzik [this message]
2005-09-16  0:07     ` izvekov
2005-10-22 11:55     ` problem with libata and ich6m - 2.6.14-rc5 Raphael Jacquot
2005-10-22 12:18       ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43321B19.7000302@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=izvekov@lps.ele.puc-rio.br \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.