From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Herton Ronaldo Krzesinski <herton@mandriva.com.br>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtl8187: Fix for change in STA handling in mac80211
Date: Thu, 11 Dec 2008 19:24:22 +0000 (GMT) [thread overview]
Message-ID: <433348.77904.qm@web23102.mail.ird.yahoo.com> (raw)
In-Reply-To: <494132C3.5070907@lwfinger.net>
--- On Thu, 11/12/08, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Hin-Tak Leung wrote:
> >
> > I don't know the verdict yet - but I think we need
> to either revert Johannes's earlier patch, or have this
> change from Larry incoporated, ASAP.
> >
> > Hin-Tak
>
> No, the best solution is to incorporate Johannes patch of
> today. Now that I
> understand what happened, my patch just wallpapers over his
> mistake.
>
> To explain how that happened, he used
> NL80211_IFTYPE_STATION (2) when he meant
> BIT(NL80211_IFTYPE_STATION)(4). My "fix" works
> because BIT(NL80211_IFTYPE_ADHOC)
> == NL80211_IFTYPE_STATION.
Found Johannes's new patch - and using it right now. So I could have a
Tested-by: ... Yes, it makes more sense :-).
Hin-Tak
prev parent reply other threads:[~2008-12-11 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 1:59 [PATCH] rtl8187: Fix for change in STA handling in mac80211 Larry Finger
2008-12-11 8:26 ` Johannes Berg
2008-12-11 11:58 ` Hin-Tak Leung
2008-12-11 12:17 ` Hin-Tak Leung
2008-12-11 15:33 ` Larry Finger
2008-12-11 17:33 ` Hin-Tak Leung
2008-12-11 17:37 ` Stefanik Gábor
2008-12-11 19:24 ` Hin-Tak Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433348.77904.qm@web23102.mail.ird.yahoo.com \
--to=htl10@users.sourceforge.net \
--cc=Larry.Finger@lwfinger.net \
--cc=herton@mandriva.com.br \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.