From: Arnd Bergmann <arnd@arndb.de>
To: y2038@lists.linaro.org
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
outreachy-kernel <outreachy-kernel@googlegroups.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [Y2038] [Outreachy kernel] [PATCH v2] misc: ibmasm: Replace timeval with timespec64
Date: Fri, 23 Oct 2015 16:21:38 +0200 [thread overview]
Message-ID: <4334098.D135Jbk2rc@wuerfel> (raw)
In-Reply-To: <CA+5yK5HXwj8fgv5wOmZgJ0hneotaaYvV+-r_DVB=GztoPtmG_Q@mail.gmail.com>
On Friday 23 October 2015 19:28:00 Amitoj Kaur Chawla wrote:
> On Fri, Oct 23, 2015 at 7:17 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Friday 23 October 2015 15:39:49 Arnd Bergmann wrote:
> >> On Friday 23 October 2015 17:52:06 Amitoj Kaur Chawla wrote:
> >> > This patch replaces timeval with timespec64 as 32 bit 'struct timeval'
> >> > will not give current time beyond 2038.
> >> >
> >> > The patch changes the code to use ktime_get_real_ts64() which returns
> >> > a 'struct timespec64' instead of do_gettimeofday() which returns a
> >> > 'struct timeval'
> >> >
> >> > This patch also alters the format strings in sprintf() for now.tv_sec and
> >> > now.tv_nsec to incorporate 'long long' on 32 bit architectures and
> >> > leading zeroes respectively.
> >> >
> >> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> >>
> >> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I was going to suggest to send this to the maintainers now, but after
> > checking the MAINTAINERS file myself, I see that this would be Greg and me
> >
> > Greg, can you pick this up into the char-misc tree?
> >
> > Arnd
>
> Hi Arnd,
>
> I made a slight error while sending v2 which I caught after figuring
> out of my issue of compiling the module.
>
> I'm sending a v3 after build testing it.
>
> Should I cc you and Greg separately or let it be?
In general, it helps to Cc maintainers. We are good at ignoring duplicate
mails.
Arnd
prev parent reply other threads:[~2015-10-23 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 12:22 [PATCH v2] misc: ibmasm: Replace timeval with timespec64 Amitoj Kaur Chawla
2015-10-23 13:39 ` [Outreachy kernel] " Arnd Bergmann
2015-10-23 13:47 ` Arnd Bergmann
2015-10-23 13:58 ` Amitoj Kaur Chawla
2015-10-23 14:21 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4334098.D135Jbk2rc@wuerfel \
--to=arnd@arndb.de \
--cc=amitoj1606@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.