All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anders Grafstrom <grfstrm@users.sourceforge.net>
To: dedekind@infradead.org
Cc: linux-mtd@lists.infradead.org
Subject: Re: mtd/fs/jffs2 erase.c,1.84,1.85 roll back
Date: Fri, 23 Sep 2005 17:22:53 +0200	[thread overview]
Message-ID: <43341DCD.6090002@users.sourceforge.net> (raw)
In-Reply-To: <1127399674.28625.18.camel@sauron.oktetlabs.ru>

Artem B. Bityutskiy wrote:
> On Tue, 2005-09-20 at 21:49 +0200, Anders Grafstrom wrote:
> 
>>So if we return -EIO, then we go to jffs2_erase_failed(). For NAND, if 
>>the MTD driver reported erase failure (bad_offset != 0xffffffff), a 
>>retry is made before giving up on the block and marking it bad. Also the 
>>read operation may have failed, erase may have failed and MTD missed it, 
>>write of clean marker may have failed. As it is these cases will put the 
>>block on the bad_list. In the case of NOR it will also be put on the 
>>bad_list at once.
>>But how about retrying for all of these cases?
> 
> 
> Sorry, no more today. What does your patch do? Adds the second try? What
> for?
> 

jffs2 makes a second try if a failed erase is reported by the mtd 
driver. But only for NAND (in jffs2_write_nand_badblock()). What I'm 
after is a retry for NOR as well. But I wrote the patch so it would 
retry for other cases of failure too.

Regards,
  Anders

  reply	other threads:[~2005-09-23 15:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1EHjUk-0001IT-Dn@phoenix.infradead.org>
     [not found] ` <43303409.5030406@users.sourceforge.net>
2005-09-20 16:48   ` mtd/fs/jffs2 erase.c,1.84,1.85 roll back Artem B. Bityutskiy
2005-09-20 19:49     ` Anders Grafstrom
2005-09-22 14:34       ` Artem B. Bityutskiy
2005-09-23 15:22         ` Anders Grafstrom [this message]
2005-09-25 12:54           ` Jörn Engel
2005-09-26  8:03             ` Artem B. Bityutskiy
2005-09-26  8:31               ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43341DCD.6090002@users.sourceforge.net \
    --to=grfstrm@users.sourceforge.net \
    --cc=dedekind@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.