From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiaofeng Ling Subject: Re: [PATCH][VT] Fix vnc configure problem for vmx guest Date: Mon, 26 Sep 2005 09:51:17 +0800 Message-ID: <43375415.1040406@intel.com> References: <3ACA40606221794F80A5670F0AF15F840999E329@pdsmsx403> <20050923160027.GL2439@uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20050923160027.GL2439@uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ewan Mellor Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Ewan Mellor wrote: > On Fri, Sep 23, 2005 at 11:12:26PM +0800, Ling, Xiaofeng wrote: > > >>see attach mail. That is why configVNC is seperated. >>I know this fix is not seems so ideal, >>I'd like to know if you have good idea for the problem. > > > Thanks for that. I've had a look, and I don't see any reason for ImageHandler > to be created before the domain itself, so I've moved the ImageHandler.create > call so that it is after the xc.domain_create call. This means that you have > the domid available inside configVNC, as necessary. > > The change will be pushed to the public server in the next few minutes. Let > me know how you get on. Yes, moving ImageGandler.create after domain create resolves the problem. but I guess the original purpose of putting ImageHandler.create after domain creating maybe if ImageHanler.ceate fails(some configuration wrong), there'll be no useless domain struct exists. So I seperates the configVNC and put it after the domain creating. Maybe better way is have a pre-config and post-config?