From: mds@mds.gotdns.com (Mark Studebaker)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] fix SW PEC for write byte data
Date: Mon, 26 Sep 2005 23:27:44 +0000 [thread overview]
Message-ID: <43386789.3010004@mds.gotdns.com> (raw)
In-Reply-To: <200509240819.AA01317@k7.kit.hi-ho.ne.jp>
Jean Delvare wrote:
> Konbanwa Hideki,
>
>
>>@@ -979,7 +979,7 @@
>> break;
>> case I2C_SMBUS_BYTE_DATA:
>> buf[2] = data->byte;
>>- data->word = buf[2] ||
>>+ data->word = buf[2] |
>> (i2c_smbus_pec(3, buf, NULL) << 8);
>> size = I2C_SMBUS_WORD_DATA;
>> break;
>
>
> Eek, this one was weird :( Looks like nobody ever used this code.
> Thanks a lot for reporting all these errors in our code. I've committed
> your fix to i2c CVS already and will port it to Linux 2.6 as well.
>
> Arigato,
ha
of course I take blame and credit for PEC bugs.
PEC really used for block transfers (including ARP and the IPMI-over-I2C_, not familiar with any chip using it
for single bytes.
next prev parent reply other threads:[~2005-09-26 23:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-24 10:19 [lm-sensors] [PATCH] fix SW PEC for write byte data Hideki IWAMOTO
2005-09-24 19:14 ` Jean Delvare
2005-09-26 23:27 ` Mark Studebaker [this message]
2005-09-27 9:46 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43386789.3010004@mds.gotdns.com \
--to=mds@mds.gotdns.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.