All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: "Greg Kurz" <groug@kaod.org>, "Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v3] 9pfs: deprecate 'proxy' backend
Date: Wed, 21 Jun 2023 18:44:33 +0200	[thread overview]
Message-ID: <4339157.nmqpxYUvy1@silver> (raw)
In-Reply-To: <ZJMXIajM3y6BSPlm@redhat.com>

On Wednesday, June 21, 2023 5:28:33 PM CEST Daniel P. Berrangé wrote:
[...]
> > > I'm fine with deprecating this. In terms of messaging wrt replacements,
> > > we should highlight both the 9p 'local' backend, and virtiofsd as the
> > > two alternatives. The latter is likely the better choice (on linux
> > > hosts) for many.
> > 
> > OK, I can add that to the deprecation doc, but you don't want that to be
> > added to all the runtime warnings as well, do you?
> 
> I'd suggest we could do mention it briefly as an option at rutime, eg
> 
> warn_report("'-virtfs proxy' is deprecated, use '-virtfs local' or virtiofs instead");

I asked because with what Greg already suggested, it starts to become a long
runtime message, like:

  "'-fsdev proxy' and '-virtfs proxy' are deprecated, use 'local' instead of
   'proxy' or virtiofs"

And that's probably still ambiguous, becauses that might suggest people that
they could simply s/-virtfs proxy/-virtfs virtiofs/.

Low care rate on my end though.

Best regards,
Christian Schoenebeck




      reply	other threads:[~2023-06-21 16:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-10 13:39 [PATCH v3] 9pfs: deprecate 'proxy' backend Christian Schoenebeck
2023-06-12 14:57 ` [SPAM] " Greg Kurz
2023-06-15  9:35 ` Christian Schoenebeck
2023-06-21 13:32   ` Christian Schoenebeck
2023-06-21 13:41     ` Greg Kurz
2023-06-21 14:16       ` Christian Schoenebeck
2023-06-21 14:58         ` Greg Kurz
2023-06-21 13:39   ` Daniel P. Berrangé
2023-06-21 13:46 ` Daniel P. Berrangé
2023-06-21 14:27   ` Christian Schoenebeck
2023-06-21 15:28     ` Daniel P. Berrangé
2023-06-21 16:44       ` Christian Schoenebeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4339157.nmqpxYUvy1@silver \
    --to=qemu_oss@crudebyte.com \
    --cc=berrange@redhat.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.