Re: [ SEPOL ] Extract user records from binary policy

[Ivan Gyurdiev <ivg2@cornell.edu>]

Stephen Smalley wrote:

>On Mon, 2005-09-26 at 21:34 -0400, Ivan Gyurdiev wrote:
>  
>
>>>I understand that you are trying to just re-use the existing mls_
>>>functions here, but I think it would be better to alter them or add new
>>>ones that provide a saner interface for this kind of manipulation.  In
>>>particular, the manipulation of str above makes me nervous, even if it
>>>is technically correct.
>>> 
>>>
>>>      
>>>
>>Yes, I agree the mls interface should be improved... so I don't have to 
>>write things like:
>>
>>                if (mls_context_to_sid(policydb, '$', &mls_level, 
>>&context)) {
>>                        DEBUG(__FUNCTION__, "invalid level %s for user 
>>%s\n",
>>                                mls_level, name);
>>                        goto err;
>>                }
>>    
>>
>
>Yes.  The interface did make sense for its original usage, but not for
>the way in which it is being used here. 
>  
>
Well, I could define a new function which allocates the string (after 
computing proper length), writes to it, and returns a valid ptr... 
however that's just moving the potential point of failure from two calls 
in users.c into one function in mls.c....

Like this?

int sepol_mls_struct_to_string(policydb_t* policydb, context_struct_t* 
mls, char** str).
int sepol_mls_struct_from_string(policydb_t* policydb, char* str, 
context_struct_t** mls).

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.