From: Jeff Garzik <jgarzik@pobox.com>
To: Greg KH <greg@kroah.com>
Cc: Grant Coady <grant_lkml@dodo.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries
Date: Tue, 27 Sep 2005 17:23:08 -0400 [thread overview]
Message-ID: <4339B83C.9020103@pobox.com> (raw)
In-Reply-To: <20050926213557.GA21973@kroah.com>
Greg KH wrote:
> I don't think you need the change to the comments at the top of the
> file.
agreed.
> Also, I thought we wanted to keep all of the pci class ids, why did you
> delete them? We should start by removing the pci device and vendor ids
> that are not currently used by the kernel, and then slowly move those
> ids into the individual drivers, starting with the device ids, and maybe
> eventually moving to the vendor ids.
The vendor ids are OBVIOUSLY common constants. The proper place is
where they live now: pci_ids.h.
I see little value in moving referenced device ids into individual
drivers, as they will make them harder to grep for, as time passes.
Jeff
next prev parent reply other threads:[~2005-09-27 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-19 11:22 [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries Grant Coady
2005-09-26 21:35 ` Greg KH
2005-09-27 8:32 ` Grant Coady
2005-09-27 8:36 ` Greg KH
2005-09-27 21:23 ` Jeff Garzik [this message]
2005-09-27 22:04 ` Grant Coady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4339B83C.9020103@pobox.com \
--to=jgarzik@pobox.com \
--cc=grant_lkml@dodo.com.au \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.