From: Jeff Garzik <jgarzik@pobox.com>
To: Lukasz Kosewski <lkosewsk@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3] Add disk hotswap support to libata RESEND #5
Date: Wed, 28 Sep 2005 16:04:55 -0400 [thread overview]
Message-ID: <433AF767.205@pobox.com> (raw)
In-Reply-To: <355e5e5e050928124651ba8947@mail.gmail.com>
Lukasz Kosewski wrote:
> No. ata_device_add returns nonzero on success; so say the docs.
Whoops, you're right. I forget it was special.
> Since the return value is not checked here, and whether on success or
> failure all of the data structures allocated in that method stick
> around, I assumed that something was in the works for this. I'll
> change this to kfree(hp) on returning 0. Please advise if I should do
> something else.
It still needs to clean up after pdc_host_init()...
Jeff
prev parent reply other threads:[~2005-09-28 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 1:01 [PATCH 1/3] Add disk hotswap support to libata RESEND #5 Lukasz Kosewski
2005-09-28 18:55 ` Jeff Garzik
2005-09-28 19:46 ` Lukasz Kosewski
2005-09-28 20:04 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433AF767.205@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkosewsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.