From: Mark Lord <lkml@rtr.ca>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org,
Justin Piszcz <jpiszcz@lucidpixels.com>,
Nuno Silva <nuno.silva@vgertech.com>
Subject: Re: Linux SATA S.M.A.R.T. and SLEEP? -- was [PATCH libata-dev-2.6:passthru] passthru fixes
Date: Thu, 29 Sep 2005 17:53:37 -0400 [thread overview]
Message-ID: <433C6261.2050202@rtr.ca> (raw)
In-Reply-To: <20050929185245.GA28483@tuxdriver.com>
John W. Linville wrote:
> You probably want this patch as well, at least the first hunk.
> It fixes a potential memory leak that could cause lock-ups when using
> hdparm or smartctl/smartd.
>
> John
> ---
> Fix a few problems seen with the passthru branch:
>
> - leaked scsi_request on buffer allocate failure
> - passthru sense routines were refering to tf->command
> which is not read in tf_read, instead use drv_stat for
> status register.
> - passthru sense passed back to user on ata_task_ioctl
>
> Patch is against the current libata-dev passthru branch.
>
> Signed-off-by: Jeff Raubitschek <jhr@google.com>
...
When I tried that patch recently, smartctl stopped working.
Reverted. Works again.
??
next prev parent reply other threads:[~2005-09-29 21:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 13:17 Linux SATA S.M.A.R.T. and SLEEP? Justin Piszcz
2005-09-29 18:26 ` Nuno Silva
2005-09-29 18:33 ` Justin Piszcz
2005-09-29 17:53 ` jmerkey
2005-09-29 19:35 ` Grant Coady
2005-09-29 18:19 ` jmerkey
2005-09-30 8:36 ` Alistair John Strachan
2005-10-03 16:32 ` Bill Davidsen
2005-10-03 21:05 ` Mark Lord
2005-10-03 21:54 ` Bill Davidsen
2005-10-03 21:54 ` jmerkey
2005-09-29 18:52 ` Linux SATA S.M.A.R.T. and SLEEP? -- was [PATCH libata-dev-2.6:passthru] passthru fixes John W. Linville
2005-09-29 21:53 ` Mark Lord [this message]
2005-09-30 1:50 ` John W. Linville
2005-09-29 19:31 ` Linux SATA S.M.A.R.T. and SLEEP? Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433C6261.2050202@rtr.ca \
--to=lkml@rtr.ca \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nuno.silva@vgertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.