From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Pavel Roskin <proski@gnu.org>, git@vger.kernel.org
Subject: Re: [PATCH] Fix gcc-4 warning in accept() call
Date: Thu, 29 Sep 2005 22:53:43 -0700 [thread overview]
Message-ID: <433CD2E7.5090909@zytor.com> (raw)
In-Reply-To: <7vachv9kbq.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Pavel Roskin <proski@gnu.org> writes:
>
>
>>gcc-4 warns about sign mismatch in pointers. Third argument in accept()
>>is socklen_t, which is unsigned. Since Linus doesn't like socklen_t
>>(see commit 7fa090844f7d1624c7d1ffc621aae6aec84a1110), let's use
>>unsigned int.
>
> Based on the list comments, I'd drop this patch -- it appears
> that gcc-4 warning is useless in this case.
>
No, it's not. The proper type, if you don't use socklen_t, is int, not
unsigned int.
-hpa
next prev parent reply other threads:[~2005-09-30 5:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 21:05 [PATCH] Fix gcc-4 warning in accept() call Pavel Roskin
2005-09-29 23:11 ` Horst von Brand
2005-09-30 4:09 ` Pavel Roskin
2005-09-30 4:46 ` H. Peter Anvin
2005-09-30 5:49 ` Junio C Hamano
2005-09-30 5:53 ` H. Peter Anvin [this message]
2005-09-30 5:58 ` H. Peter Anvin
2005-09-30 6:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433CD2E7.5090909@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.