From: Dinolinux <slackfan@users.sourceforge.net>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] printk: arch/i386/kernel/doublefault.c
Date: Fri, 30 Sep 2005 19:03:31 +0000 [thread overview]
Message-ID: <433DA691.6080804@users.sourceforge.net> (raw)
printk() should include the appropriate KERN_* constant.
--- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c 2005-09-20
05:00:41.000000000 +0200
+++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c 2005-09-30
22:40:50.000000000 +0200
@@ -23,23 +23,23 @@ static void doublefault_fn(void)
store_gdt(&gdt_desc);
gdt = gdt_desc.address;
- printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
+ printk(KERN_ERR"double fault, gdt at %08lx [%d bytes]\n", gdt,
gdt_desc.size);
if (ptr_ok(gdt)) {
gdt += GDT_ENTRY_TSS << 3;
tss = *(u16 *)(gdt+2);
tss += *(u8 *)(gdt+4) << 16;
tss += *(u8 *)(gdt+7) << 24;
- printk("double fault, tss at %08lx\n", tss);
+ printk(KERN_ERR"double fault, tss at %08lx\n", tss);
if (ptr_ok(tss)) {
struct tss_struct *t = (struct tss_struct *)tss;
- printk("eip = %08lx, esp = %08lx\n", t->eip, t->esp);
+ printk(KERN_ERR"eip = %08lx, esp = %08lx\n", t->eip, t->esp);
- printk("eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",
+ printk(KERN_ERR"eax = %08lx, ebx = %08lx, ecx = %08lx, edx
= %08lx\n",
t->eax, t->ebx, t->ecx, t->edx);
- printk("esi = %08lx, edi = %08lx\n",
+ printk(KERN_ERR"esi = %08lx, edi = %08lx\n",
t->esi, t->edi);
}
}
This is my first patch so please be nice to me ;-) . I've tried to make
it as good and correct as I could so there shouldn't be _too_ much
errors. Hope this is the right way to do this...
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-09-30 19:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-30 19:03 Dinolinux [this message]
2005-09-30 19:33 ` [KJ] [PATCH] printk: arch/i386/kernel/doublefault.c Nish Aravamudan
2005-09-30 21:18 ` [KJ] [PATCH] printk: arch/i386/kernel/doublefault.c [UPDATED] Dinolinux
2005-09-30 21:32 ` Nishanth Aravamudan
2005-10-01 8:35 ` [KJ] [PATCH] printk: arch/i386/kernel/doublefault.c Tobias Klauser
2005-10-01 16:00 ` Powerflash
2005-10-02 9:45 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433DA691.6080804@users.sourceforge.net \
--to=slackfan@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.