All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: motomu <motomu@hongo.wide.ad.jp>
Cc: dev@dpdk.org
Subject: Re: [PATCH] drivers/net/e1000/igb_ethdev.c:fix eth_igb_add_del_flex_filter
Date: Fri, 10 Jul 2015 16:48:27 +0200	[thread overview]
Message-ID: <4340982.5yr692ncls@xps13> (raw)
In-Reply-To: <1432484252-3517-1-git-send-email-motomu@hongo.wide.ad.jp>

We definitely need a maintainer for e1000.

2015-05-24 16:17, motomu:
> From: Motomu Utsumi <motomu@hongo.wide.ad.jp>
> 
> in add flexfiler it always write to same register address,
> so when try to adapt some filters only last one is enabled.
> I substitute value based on based on flex_filter->index for reg_off.
> 
> in del flexfilter, it delete target filter and 
> also delete first filter because of similar reason.
> I substitute value based on based on it->index for reg_off.

You forgot a Signed-off.

[...]
>  		}
> +    if (flex_filter->index < E1000_MAX_FHFT)
> +      reg_off = E1000_FHFT(flex_filter->index);
> +    else
> +      reg_off = E1000_FHFT_EXT(flex_filter->index - E1000_MAX_FHFT);

On the formatting side, it seems indent is wrong.

  reply	other threads:[~2015-07-10 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-24 16:17 [PATCH] drivers/net/e1000/igb_ethdev.c:fix eth_igb_add_del_flex_filter motomu
2015-07-10 14:48 ` Thomas Monjalon [this message]
2015-07-13  9:00 ` Lu, Wenzhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4340982.5yr692ncls@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=motomu@hongo.wide.ad.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.