From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0/2] Change xs_read_watch interfaces to support variable arguments Date: Mon, 03 Oct 2005 23:48:17 -0500 Message-ID: <43420991.3070905@us.ibm.com> References: <4342087F.5010505@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4342087F.5010505@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: Rusty Russell , xen-devel , Christian Limpach List-Id: xen-devel@lists.xenproject.org I should mention that I ran the xenstore testsuite (which rocks btw) and tested the block devices and network devices. I haven't tested blktap and vtpm but the changes are identical (and I don't have any test cases for those). Regards, Anthony Liguori Anthony Liguori wrote: > The following set of changes modify the read_watch interface in > userspace and in the kernel to support variable arguments. This is in > preparation for adding domid to @{introduce,release}Domain watches. > This will allow backends to automatically reap on domain destruction > which should eliminate a large number of the zombie problems we're > having on domain destruction since Xend no longer plays a role in > freeing that memory. > > The interface for read_watch is now consistent between userspace and > kernel space. It's modelled after xs_read_directory. The returned > array is indexable via XS_WATCH_* macros. > > While slightly awkward, IMHO it seems like the cleanest and most > flexible option of the proposed interfaces. > > Signed-off-by: Anthony Liguori > > Regards, > > Anthony Liguori > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >