From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nivedita Singhvi <niv@us.ibm.com>
Subject: Re: [PATCH] Fix tools makefile to properly check for
	external tools
Date: Tue, 04 Oct 2005 12:15:35 -0700
Message-ID: <4342D4D7.7030108@us.ibm.com>
References: <1128451606.15111.10.camel@thinkpad>
	<1128452681.15111.14.camel@thinkpad>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1128452681.15111.14.camel@thinkpad>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jerone Young <jyoung5@us.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Jerone Young wrote:

> Ok ,thinking about the comment in tools/check/Makefile is so that one
> could install stuff in "dist" directory. But our networking scripts have
> no checks at all to see if (for example) "brctl" is even there...it just
> silently installs. So given this when would one check that we have
> everything need installed. Also I will submit a patch to add a check to
> the network script to see if the tools are actually on the system.

Hi Jerone,

I had a patch that did that a while ago, but the feeling at
the time was that it wasn't the right place - it should be in
a make check or some top level script (?).

It's not just that script, it's all the rest, too. The con was
that somethings you can't roll back from (previous scripts),
and so even putting them at the top of each script wasn't
sufficient.

thanks,
Nivedita


> On Tue, 2005-10-04 at 13:46 -0500, Jerone Young wrote:
> 
>>Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>>
>>Fix tools makefile so that extrnal tools checks are run to ensure
>>extrnal tools  are actually installed.
>>
>>diff -r 00037ba13f0b -r cc75d51355cb tools/Makefile
>>--- a/tools/Makefile    Tue Oct  4 17:23:58 2005
>>+++ b/tools/Makefile    Tue Oct  4 16:28:18 2005
>>@@ -33,7 +33,7 @@
>>        done
>>        $(MAKE) ioemu
>>
>>-install: check
>>+install: check_install
>>        @set -e; for subdir in $(SUBDIRS); do \
>>                $(MAKE) -C $$subdir $@; \
>>        done
>>@@ -48,6 +48,9 @@
>> check:
>>        $(MAKE) -C check
>>
>>+check_install:
>>+       $(MAKE) -C check install
>>+
>> check_clean:
>>        $(MAKE) -C check clean
>>
>>