From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EMvpc-000319-07 for qemu-devel@nongnu.org; Tue, 04 Oct 2005 19:04:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EMvpY-0002zk-1v for qemu-devel@nongnu.org; Tue, 04 Oct 2005 19:04:17 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EMvpW-0002yr-EW for qemu-devel@nongnu.org; Tue, 04 Oct 2005 19:04:14 -0400 Received: from [206.46.252.42] (helo=vms042pub.verizon.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EMvpW-0007qJ-7O for qemu-devel@nongnu.org; Tue, 04 Oct 2005 19:04:14 -0400 Received: from [192.168.0.100] ([141.154.224.126]) by vms042.mailsrvcs.net (Sun Java System Messaging Server 6.2 HotFix 0.04 (built Dec 24 2004)) with ESMTPA id <0INU003ZYYQZ65X6@vms042.mailsrvcs.net> for qemu-devel@nongnu.org; Tue, 04 Oct 2005 18:04:12 -0500 (CDT) Date: Tue, 04 Oct 2005 19:03:32 -0400 From: John Coiner Subject: Re: [Qemu-devel] [patch] non-blocking disk IO In-reply-to: <4342E8B7.8050507@wasp.net.au> Message-id: <43430A44.7010403@stanfordalumni.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7bit References: <4340D479.7030301@stanfordalumni.org> <4342E8B7.8050507@wasp.net.au> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, brad@wasp.net.au Brad Campbell wrote: > With this patch qemu will not boot the qcow files but will boot the base > images (I copy them and then try to boot to test). As soon as I patch -R > && make, qemu will boot the qcow files no problems.. > > Let me clarify that.. > qemu-img create -f qcow xp.img 4G > qemu -cdrom xp.iso -hda xp.img -boot d (Install XP from scratch) > qemu-img create -b xp.img -f qcow xp2.img > qemu -hda xp2.img > > This gives me an invalid hard disk error. If I revert the patch I can > boot from xp2.img with no issues. With or without the patch I can boot > from xp.img. > > I have tried installing XP with and without the patch and that works fine.. > > Regards, > Brad Thanks for the report. I was able to reproduce this. The problem was due to missing Makefile dependencies. The patch modifies 'block_int.h', which is #included in several '.c' files. The file 'block.c' recompiled at 'make' time, but 'block-qcow.c' didn't. The resulting '.o' files had different opinions about what a BlockDriverState struct looked like, which broke the qcow code. Unaware of this, I added a printf to 'block-qcow.c', and the printf fixed the problem! The man page for printf doesn't mention this... and then I was enlightened. :P To be safe, try a 'make clean ; make install' and you should be all good. Let me know if not. -- John