From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95E1EC47258 for ; Wed, 10 Jan 2024 11:42:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3A98386758; Wed, 10 Jan 2024 12:42:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="QqNlgvpo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D286F87A35; Wed, 10 Jan 2024 12:42:18 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3482F86314 for ; Wed, 10 Jan 2024 12:42:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9B6A4616F6; Wed, 10 Jan 2024 11:42:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4C90C43390; Wed, 10 Jan 2024 11:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704886934; bh=EogRMTihidm679Q7v/jvaIeUNmvzpcPVwEni1YRd8A8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QqNlgvpogaeXEA0JRQCVgIPpdn/PEUTOBJHUvmhMbAD9+wnKDNUj99LTsE4mmmw5W 8JGigf9O7JNgXvbdny6O4v6v0740woTvzygHnVbZHOasAd96DkqRttmTf6scXR84PL 4uQaqpeeR3xQFvNG6jZJE2l2MY6ONVSE7X5Uaa8r34n5IrFpfdwwfxflg8kuwJMKu1 0FNCcPTzKW3NmjYlmbA4aGN1E3cIyiPYLm/j9GRsU18Wdynq0VIP0B60LPG0avGUk6 IfA2xEDZKnbWFAECrd9oO6nLCzqgLDfkdceXFIG1RDSkXItgHwIH/pJWTEtC6Xp0gB bOISZNd7AMegw== Message-ID: <434376df-5861-4fa5-8cdf-894a3639a065@kernel.org> Date: Wed, 10 Jan 2024 13:42:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 12/16] arm: dts: k3-am65x-binman: Add ICSSG2 overlay and configuration To: MD Danish Anwar , Maxime Ripard , Siddharth Vadapalli , Nishanth Menon , Vignesh Raghavendra , Matthias Schiffer , Kamlesh Gurudasani , Manorit Chawdhry , Neha Malcom Francis , Andrew Davis , Ramon Fried , Joe Hershberger , Simon Glass , Tom Rini Cc: u-boot@lists.denx.de, srk@ti.com, r-gunasekaran@ti.com References: <20231219103418.3445886-1-danishanwar@ti.com> <20231219103418.3445886-13-danishanwar@ti.com> <1745ec33-7446-41fc-886a-704eb6e53c7e@kernel.org> <427c0741-5daf-4370-9cf6-5c70d8d6f673@ti.com> Content-Language: en-US From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 10/01/2024 11:02, MD Danish Anwar wrote: > > > On 10/01/24 2:24 pm, Roger Quadros wrote: >> On 10/01/2024 08:50, MD Danish Anwar wrote: >>> Hi Roger, >>> >>> On 27/12/23 3:49 pm, MD Danish Anwar wrote: >>>> On 20/12/23 4:10 pm, Roger Quadros wrote: >>>>> >>>>> >>>>> On 19/12/2023 12:34, MD Danish Anwar wrote: >>>>>> Add ICSSG2 overlay and configuration to tispl and u-boot images. >>>>>> >>>>>> Signed-off-by: MD Danish Anwar >>>>>> --- >>>>>> arch/arm/dts/k3-am65x-binman.dtsi | 85 +++++++++++++++++++++++++++++++ >>>>>> 1 file changed, 85 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/dts/k3-am65x-binman.dtsi b/arch/arm/dts/k3-am65x-binman.dtsi >>>>>> index 8cc24da1f3..9a0c0fca47 100644 >>>>>> --- a/arch/arm/dts/k3-am65x-binman.dtsi >>>>>> +++ b/arch/arm/dts/k3-am65x-binman.dtsi >>>>>> @@ -98,6 +98,8 @@ >>>>>> #define SPL_AM654_EVM_DTB "spl/dts/k3-am654-base-board.dtb" >>>>>> #define AM654_EVM_DTB "u-boot.dtb" >>>>>> >>>>>> +#define AM654_EVM_ICSSG2_DTBO "arch/arm/dts/k3-am654-icssg2.dtbo" >>>>>> + >>>>>> &binman { >>>>>> ti-spl { >>>>>> insert-template = <&ti_spl_template>; >>>>>> @@ -124,6 +126,20 @@ >>>>>> filename = SPL_AM654_EVM_DTB; >>>>>> }; >>>>>> }; >>>>>> + >>>>>> + fdt-1 { >>>>>> + description = "k3-am654-icssg2 overlay"; >>>>>> + type = "flat_dt"; >>>>>> + arch = "arm"; >>>>>> + compression = "none"; >>>>>> + ti-secure { >>>>>> + content = <&spl_am65x_evm_icssg2_dtb>; >>>>>> + keyfile = "custMpk.pem"; >>>>>> + }; >>>>>> + spl_am65x_evm_icssg2_dtb: blob-ext { >>>>>> + filename = AM654_EVM_ICSSG2_DTBO; >>>>>> + }; >>>>> >>>>> This is wrong. >>>>> >>>>> ICSSG2 Ethernet should be part of the fdt-0 configuration as the 2 Ethernet ports >>>>> on the board are hardwired to ICSSG2. Not having them working by default >>>>> is an invalid configuration. >>>>> >>>> >>>> ICSSG2 ethernet ports should be enabled by default. But the ICSSG2 nodes >>>> is added in the overlay file (k3-am654-icssg2.dtso) in kernel so they >>>> are added in same overlay file in u-boot as well. >>>> >>>> I am keeping, >>>> fdt-0 as k3-am654-base-board dtb, >>>> fdt-1 as k3-am654-icssg2 dtbo, >>>> conf-0 as k3-am654-base-board and >>>> conf-1 as k3-am654-icssg2. >>>> >>>> Do you want me to keep k3-am654-icssg2 dtbo as fdt-0 and >>>> k3-am654-base-board as fdt-1? I tried doing this but this results into >>>> u-boot getting stuck. The tispl and u-boot images are not able to load >>>> if I swap fdt-0 and fdt-1 , and conf-0 and conf-1. >>>> >>>> If the current combination doesn't look OK, please let me know what >>>> should be the correct combinations for fdt-0, fdt-1, conf-0 and conf-1. >>>> >>> >>> Can you please comment on this. I'll send v2 with all the suggested >>> changes once you confirm the correct fdt and configurations. >>> >> Sorry, I missed this. >> >> fdt-0 = k3-am654-base-board dtb >> fdt-1 = k3-am654-icssg2 dtbo >> >> conf-0 = fdt-0 and ftd-1 >> > > What about conf-1? Should I leave it as it is(currently conf-1 is fdt-0 > and fdt-1)? I don't think we need conf-1. > >> as icssg2 ethernet is present on the base board, and should be part of the base board configuration. >> > -- cheers, -roger