From: Jeff Garzik <jgarzik@pobox.com>
To: Brett Russ <russb@emc.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Pasi Pirhonen <upi@papat.org>,
Michael Madore <Michael.Madore@aslab.com>,
Bogdan Costescu <Bogdan.Costescu@iwr.uni-heidelberg.de>,
"Mr. Berkley Shands" <bshands@exegy.com>,
Jim Edwards <jim@networkdesigning.com>,
scott olson <scotto701@yahoo.com>,
Lars Magne Ingebrigtsen <larsi@gnus.org>,
Evgeny Rodichev <er@sai.msu.su>
Subject: Re: [PATCH 2.6.14-rc2 1/2] libata: Marvell spinlock fixes and simplification
Date: Wed, 05 Oct 2005 17:18:53 -0400 [thread overview]
Message-ID: <4344433D.5090305@pobox.com> (raw)
In-Reply-To: <434442D9.5010800@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 143 bytes --]
Also, I just applied the attached patch, to kill a warning:
drivers/scsi/sata_mv.c:471: warning: 'mv_dump_mem' defined but not used
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 558 bytes --]
diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -467,9 +467,9 @@ static void mv_stop_dma(struct ata_port
}
}
+#ifdef ATA_DEBUG
static void mv_dump_mem(void __iomem *start, unsigned bytes)
{
-#ifdef ATA_DEBUG
int b, w;
for (b = 0; b < bytes; ) {
DPRINTK("%p: ", start + b);
@@ -479,8 +479,9 @@ static void mv_dump_mem(void __iomem *st
}
printk("\n");
}
-#endif
}
+#endif
+
static void mv_dump_pci_cfg(struct pci_dev *pdev, unsigned bytes)
{
#ifdef ATA_DEBUG
next prev parent reply other threads:[~2005-10-05 21:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 21:06 [PATCH 2.6.14-rc2 0/2] libata: Marvell SATA support (v0.23-0.24) Brett Russ
2005-10-05 21:08 ` [PATCH 2.6.14-rc2 1/2] libata: Marvell spinlock fixes and simplification Brett Russ
2005-10-05 21:17 ` Jeff Garzik
2005-10-05 21:18 ` Jeff Garzik [this message]
2005-10-05 22:35 ` Michael Madore
2005-10-06 11:52 ` Brett Russ
2005-10-10 19:10 ` Michael Madore
2005-10-05 21:08 ` [PATCH 2.6.14-rc2 2/2] libata: Marvell function headers Brett Russ
2005-10-06 12:46 ` [PATCH 2.6.14-rc2 0/2] libata: Marvell SATA support (v0.23-0.24) Bogdan Costescu
2005-10-06 13:13 ` Jeff Garzik
2005-10-06 13:31 ` Brett Russ
2005-10-06 13:36 ` Jeff Garzik
2005-10-06 14:20 ` Bogdan Costescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4344433D.5090305@pobox.com \
--to=jgarzik@pobox.com \
--cc=Bogdan.Costescu@iwr.uni-heidelberg.de \
--cc=Michael.Madore@aslab.com \
--cc=bshands@exegy.com \
--cc=er@sai.msu.su \
--cc=jim@networkdesigning.com \
--cc=larsi@gnus.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=russb@emc.com \
--cc=scotto701@yahoo.com \
--cc=upi@papat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.