From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: ATAPI corruption found
Date: Thu, 06 Oct 2005 15:12:52 +0900 [thread overview]
Message-ID: <4344C064.80103@gmail.com> (raw)
In-Reply-To: <4343A564.2060308@pobox.com>
Hi, Jeff.
Jeff Garzik wrote:
>
> When atapi_qc_complete() takes the error path, completes the SCSI
> command, SCSI EH runs, and the code attempts to complete the SCSI
> command again, this time with scsi_finish_command().
Umm.. that's how it worked until now by design. Can you elaborate how
corruption occurs?
>
> Ideally what we should be doing is simply not completing the SCSI
> command until REQUEST SENSE is complete, more accurately simulating
> autosense.
>
> I should have a fix in the next day or so, unless somebody beats me to it.
Hehheh, nobody beat you. :-)
--
tejun
next prev parent reply other threads:[~2005-10-06 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 10:05 ATAPI corruption found Jeff Garzik
2005-10-06 6:12 ` Tejun Heo [this message]
2005-10-06 9:56 ` Jeff Garzik
2005-10-06 14:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4344C064.80103@gmail.com \
--to=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.