From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] devtools: add explicit warning messages
	for forbidden tokens
Date: Fri, 02 Nov 2018 10:39:24 +0100
Message-ID: <4348558.Aku75RrXBD@xps>
References: <1541138405-6608-1-git-send-email-arnon@qwilt.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id F082A5B1E
 for <dev@dpdk.org>; Fri,  2 Nov 2018 10:39:30 +0100 (CET)
In-Reply-To: <1541138405-6608-1-git-send-email-arnon@qwilt.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/11/2018 07:00, Arnon Warshavsky:
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -49,13 +49,16 @@ check_forbidden_additions() { # <patch>
>  	awk -v FOLDERS="lib drivers" \
>  		-v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
>  		-v RET_ON_FAIL=1 \
> +		-v MESSAGE='Using rte_panic/rte_exit' \
>  		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
>  		"$1"
>  	# svg figures must be included with wildcard extension
>  	# because of png conversion for pdf docs
> +	message="Using explicit .svg extension in figures instead of .*"
>  	awk -v FOLDERS='doc' \
>  		-v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
>  		-v RET_ON_FAIL=1 \
> +		-v MESSAGE="$message" \
>  		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
>  		"$1"
>  }

Why using a variable for message in the second check?