All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Boettcher <pboettcher@kernellabs.com>
To: linux-media@vger.kernel.org
Subject: Re: [PATCH] media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB
Date: Fri, 30 Aug 2013 11:23:33 +0200	[thread overview]
Message-ID: <4349562.usGhpbsYS5@dibcom294> (raw)
In-Reply-To: <5220021C.2050700@asianux.com>

Hi (sending again due to HTML-nonsense in Mail),

On Friday 30 August 2013 10:23:24 Chen Gang wrote:
> DVB_B2C2_FLEXCOP_USB need depend on PCI, or can not pass compiling with
> allmodconfig for h8300.
> 
> The related error:
> 
>   drivers/media/usb/b2c2/flexcop-usb.c: In function
> 'flexcop_usb_transfer_exit': drivers/media/usb/b2c2/flexcop-usb.c:393:3:
> error: implicit declaration of function 'pci_free_consistent'
> [-Werror=implicit-function-declaration] pci_free_consistent(NULL,
> 
> [..]
> 
>  config DVB_B2C2_FLEXCOP_USB
>  	tristate "Technisat/B2C2 Air/Sky/Cable2PC USB"
> -	depends on DVB_CORE && I2C
> +	depends on DVB_CORE && I2C && PCI
>  	help
>  	  Support for the Air/Sky/Cable2PC USB1.1 box (DVB/ATSC) by
> Technisat/B2C2,

Instead of selecting PCI we could/should use usb_alloc_coherent() and 
usb_free_cohrerent(), shouldn't we?

--
Patrick 

      parent reply	other threads:[~2013-08-30  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  2:23 [PATCH] media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB Chen Gang
     [not found] ` <3939732.OJKiKvCJjt@dibcom294>
2013-08-30  8:32   ` Chen Gang
2013-08-30  9:23 ` Patrick Boettcher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4349562.usGhpbsYS5@dibcom294 \
    --to=pboettcher@kernellabs.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.