From: jmerkey <jmerkey@utah-nac.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: "Paolo 'Blaisorblade' Giarrusso" <blaisorblade@yahoo.it>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ext3 warning for unused var
Date: Sun, 09 Oct 2005 13:53:23 -0600 [thread overview]
Message-ID: <43497533.6090106@utah-nac.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0510091314200.31407@g5.osdl.org>
Linus Torvalds wrote:
>On Sun, 9 Oct 2005, Paolo 'Blaisorblade' Giarrusso wrote:
>
>
>>Can please someone merge this? It's the 3rd time I send it.
>>
>>
>
>I don't like #ifdef's in code.
>
>You could just have split up the quota-specific stuff into a function of
>their own: "ext3_show_quota_options()". The patch might have been larger,
>but it would actually clean up the code rather than make it uglier.
>
>Warnings are not a reason for ugly code.
>
> Linus
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
Someone needs to fix fsck.ext3 while they are at it so it doesn't barf
when reading from reisferfs filesystems and return a command return of >
2 during scanning of parttions during bootup. This looks like some sort
of anti-competitive crap and it doesn't belong in fsck.ext3 since
reiserfs is in the kernel.
J
next prev parent reply other threads:[~2005-10-09 21:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-09 19:58 [PATCH] Fix ext3 warning for unused var Paolo 'Blaisorblade' Giarrusso
2005-10-09 20:16 ` Linus Torvalds
2005-10-09 19:53 ` jmerkey [this message]
2005-10-09 21:29 ` Al Viro
2005-10-09 20:18 ` jmerkey
2005-10-09 22:08 ` Al Viro
2005-10-09 22:13 ` jmerkey
2005-10-09 23:47 ` Al Viro
2005-10-09 23:55 ` Valdis.Kletnieks
2005-10-10 1:43 ` Gene Heskett
2005-10-09 23:58 ` Valdis.Kletnieks
2005-10-09 22:47 ` jmerkey
2005-10-10 11:02 ` Andi Kleen
2005-10-28 18:23 ` Peter Osterlund
-- strict thread matches above, loose matches on Subject: below --
2005-10-06 15:35 Paolo 'Blaisorblade' Giarrusso
2005-09-29 18:40 Paolo 'Blaisorblade' Giarrusso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43497533.6090106@utah-nac.org \
--to=jmerkey@utah-nac.org \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.