From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix cygwin install issues
Date: Mon, 10 Oct 2005 10:09:07 -0700 [thread overview]
Message-ID: <434AA033.60308@zytor.com> (raw)
In-Reply-To: <7v64s571t5.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
>
> OK. It is better than dq, and the user can still work it around
> like this if she really wanted to:
>
> make bindir="Anna'\\''s Home/bin"
>
> I wish we had $(shellquote $(DESTDIR)$(bindir)) in make ;-).
Hmm... let's think about this for a second...
shellquote = '$(subst ','\'',$(1))'
$(call shellquote,$(whatever))
... seems to work just fine.
(No need to worry about ! since Make commands are always /bin/sh.)
-hpa
next prev parent reply other threads:[~2005-10-10 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-10 8:52 [PATCH] Fix cygwin install issues Jonas Fonseca
2005-10-10 9:03 ` Jonas Fonseca
2005-10-10 9:09 ` Junio C Hamano
2005-10-10 9:26 ` [PATCH] git.sh: quote all paths Jonas Fonseca
2005-10-10 9:32 ` Jonas Fonseca
2005-10-10 15:02 ` [PATCH] Fix cygwin install issues H. Peter Anvin
2005-10-10 16:51 ` Junio C Hamano
2005-10-10 17:09 ` H. Peter Anvin [this message]
2005-10-10 20:52 ` Deal with $(bindir) and friends with whitespaces Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434AA033.60308@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.