From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] fix iptables on systems with discontiguous processor ids Date: Mon, 10 Oct 2005 23:41:43 +0200 Message-ID: <434AE017.2020905@trash.net> References: <20051010164141.GG5627@rama> <20051010.141518.60492651.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: laforge@netfilter.org, netfilter-devel@lists.netfilter.org Return-path: To: "David S. Miller" In-Reply-To: <20051010.141518.60492651.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org David S. Miller wrote: > From: Harald Welte > Date: Mon, 10 Oct 2005 18:41:41 +0200 > > Why don't any of the existing interfaces on cpumasks and numbers > provide what you need here? Perhaps this routine you are adding > (highest_processor_id()) belongs in linux/cpumask.h? Perhaps > named something like "highest_possible_processor_id()" to be > consistent with the "num_possible_cpus()" naming? Even better would be a function returning the CPU ID as "physical" ID, skipping holes in the space. This would allow to save the memory for unused CPU IDs. Maybe a small table mapping "virtual" to "phyiscal" IDs?