From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: SCSI EH tidbit
Date: Thu, 13 Oct 2005 00:27:19 +0900 [thread overview]
Message-ID: <434D2B57.4010806@gmail.com> (raw)
In-Reply-To: <434D263A.1070708@pobox.com>
Hi, Jeff.
Jeff Garzik wrote:
>
> I'm thinking that __scsi_done() might be more appropriate than
> scsi_finish_command(), for use in completing commands in the EH path.
> There may need to be some timer-related mods somewhere to make that
> work, though.
Can you elaborate on why you think that would be a good idea? I see
cons but not many pros. My cons are...
* SCSI EH uses scsi_finish_command()
* iodone/err counters will be incremented twice
* has possibility of looping
--
tejun
next prev parent reply other threads:[~2005-10-12 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-12 15:05 SCSI EH tidbit Jeff Garzik
2005-10-12 15:27 ` Tejun Heo [this message]
2005-10-12 20:00 ` Jeff Garzik
2005-10-13 2:51 ` Tejun Heo
2005-10-19 3:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434D2B57.4010806@gmail.com \
--to=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.